bipinprasad commented on a change in pull request #3366:
URL: https://github.com/apache/storm/pull/3366#discussion_r548501586
##########
File path: storm-core/src/native/worker-launcher/impl/configuration.c
##########
@@ -74,17 +74,17 @@ void free_configurations() {
static int is_only_root_writable(const char *file) {
struct stat file_stat;
if (stat(file, &file_stat) != 0) {
- fprintf(ERRORFILE, "Can't stat file %s - %s\n", file, strerror(errno));
+ fprintf(ERRORFILE, "ERROR: Can't stat file %s - %s\n", file,
strerror(errno));
Review comment:
nit: consistent indent size of 4 spaces (or two as used here mostly)
nit: stylewise, c code if expressions do not need a != 0 or != NULL part,
i.e. "if (file_stat.st_uid)" instead of "if (file_stat.st_uid !=
0)"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
