[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885140028


##########
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java:
##########
@@ -88,24 +86,19 @@ public void testInsertConnectionError() {
         this.client = new JdbcClient(connectionProvider, 60);
 
         List<Column> row = createRow(1, "frank");
-        List<List<Column>> rows = new ArrayList<List<Column>>();
+        List<List<Column>> rows = new ArrayList<>();
         rows.add(row);
         String query = "insert into user_details values(?,?,?)";
 
-        thrown.expect(MultipleFailureException.class);
-        client.executeInsertQuery(query, rows);
+        assertThrows(RuntimeException.class, () -> 
client.executeInsertQuery(query, rows));

Review Comment:
   this was junit4 
https://junit.org/junit4/javadoc/4.12/org/junit/runners/model/MultipleFailureException.html
 ... not used anymore



##########
external/storm-hdfs-blobstore/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java:
##########
@@ -62,10 +61,9 @@ public class BlobStoreTest {
     public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new 
MiniDFSClusterExtension();
 
     private static final Logger LOG = 
LoggerFactory.getLogger(BlobStoreTest.class);
-    URI base;
     private static final Map<String, Object> CONF = new HashMap<>();
     public static final int READ = 0x01;
-    public static final int WRITE = 0x02;
+    // public static final int WRITE = 0x02;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org