snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885140762
##########
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java:
##########
@@ -88,24 +86,19 @@ public void testInsertConnectionError() {
this.client = new JdbcClient(connectionProvider, 60);
List<Column> row = createRow(1, "frank");
- List<List<Column>> rows = new ArrayList<List<Column>>();
+ List<List<Column>> rows = new ArrayList<>();
rows.add(row);
String query = "insert into user_details values(?,?,?)";
- thrown.expect(MultipleFailureException.class);
- client.executeInsertQuery(query, rows);
+ assertThrows(RuntimeException.class, () ->
client.executeInsertQuery(query, rows));
+ assertThrows(RuntimeException.class, () -> client.executeSql("drop
table " + tableName));
Review Comment:
MultipleFailureException was catching these two exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
