Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r10042000
--- Diff: storm-core/src/jvm/backtype/storm/metric/SystemBolt.java ---
@@ -60,6 +60,9 @@ public Object getValueAndReset() {
m.put("unusedBytes", memUsage.getCommitted() -
memUsage.getUsed());
return m;
}
+ public void updateMetricFromRPC(List<Object> params) {
--- End diff --
You are using tabs instead of spaces here. For consistency it would be
nice to switch to spaces for all of the indentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
