Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r10042871
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -186,6 +195,15 @@ public void cleanup() {
_inputs.clear();
}
+ public <T extends IMetric> T registerMetric(String name, T metric) {
--- End diff --
This method seems cumbersome. The fact that you have to call it in
addition to context.registerMetric feels error prone. I really would prefer to
have at a single method to call, and if at all possible that method would be a
part of context so that it is consistent with other bolts/spouts, even if
context needs to expose a new API to update a metric through RPC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
