Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r10302336
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -92,6 +99,49 @@ public void fail(Object msgId) {
_fail.put("id", msgId);
querySubprocess(_fail);
}
+
+ private void handleMetrics(Map action) {
+ //get metrics
+ Object nameObj = action.get("name");
+ if ( !(nameObj instanceof String) ) {
--- End diff --
null instanceof String is always false. So the check below really should
always be that the metric name is empty. This is also very minor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
