[
https://issues.apache.org/jira/browse/STORM-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960343#comment-13960343
]
Robert Joseph Evans commented on STORM-276:
-------------------------------------------
I am a bit confused by the patch, but I am not a windows guy so I could easily
be wrong.
The patch is adding %STORM_LOG_FILE% to a number of places, supervisor, ui,
nimbus, logviewer, drpc. But it is already on all command lines
https://github.com/apache/incubator-storm/blob/b0f33102c2bb206b5a7b3c929f7b5fcb50cb622c/bin/storm.cmd#L83
Isn't this just adding it to the command line twice? I could see us removing
it from line 83 so it is not a part of user commands only server ones, assuming
that was the intent.
Similarly %STORM_LOGBACK_CONFIGURATION_FILE% already appears to be on all
command lines
https://github.com/apache/incubator-storm/blob/b0f33102c2bb206b5a7b3c929f7b5fcb50cb622c/bin/storm-config.cmd#L98
I guess the new config overrides the previous one on the command line, but
wouldn't it be cleaner to make them a part of STORM_SERVER_OPTS and
STORM_CLIENT_OPTS.
Also on a side note, not something you added but would be nice to clean up, it
looks like STORM_LOGFILE in storm-config.cmd is never used.
I also don't understand all of the logging configs that are being sent in, like
-Dstorm.root.logger... appears on all command lines, but is never set by the
python code.
> Add support for logviewer in storm.cmd
> --------------------------------------
>
> Key: STORM-276
> URL: https://issues.apache.org/jira/browse/STORM-276
> Project: Apache Storm (Incubating)
> Issue Type: New Feature
> Reporter: sriharsha chintalapani
> Priority: Minor
> Attachments: STORM-276.patch
>
>
> storm.cmd doesn't have logviewer functionality as it is in storm.py
--
This message was sent by Atlassian JIRA
(v6.2#6252)
