[
https://issues.apache.org/jira/browse/STORM-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961951#comment-13961951
]
Robert Joseph Evans commented on STORM-276:
-------------------------------------------
[~sriharsha] line 54 is only called for 'classpath', 'help' and 'version' All
other commands set up the classpath and main class, then go on to line 83 where
they are used to build up the java command line.
As for STORM_LOGBACK_CLUSTER_CONF_FILE vs STORM_LOGBACK_CONFIGURATION_FILE I
really don't care which one, so long as it is clear what to set when you want
to override something.
The latest patch seems OK to me, especially for what this JIRA is intended to
support, but like I said I am not a Windows expert. I am +1 on the patch, but
another committer needs to give it a +1 too.
[~PadmaCh]
If there are pieces that storm.cmd lacks compared to the python storm, feel
free to file JIRA for those features and fix them. If you have Windows bat
experience we would gladly welcome your contributions.
> Add support for logviewer in storm.cmd
> --------------------------------------
>
> Key: STORM-276
> URL: https://issues.apache.org/jira/browse/STORM-276
> Project: Apache Storm (Incubating)
> Issue Type: New Feature
> Reporter: sriharsha chintalapani
> Priority: Minor
> Attachments: STORM-276.patch, STORM-276_1.PATCH
>
>
> storm.cmd doesn't have logviewer functionality as it is in storm.py
--
This message was sent by Atlassian JIRA
(v6.2#6252)
