[ 
https://issues.apache.org/jira/browse/STORM-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960453#comment-13960453
 ] 

sriharsha chintalapani commented on STORM-276:
----------------------------------------------

[~revans2] Thanks for the comments.
1) Regarding the STORM_LOG_FILE
commands are being called from 
https://github.com/apache/incubator-storm/blob/b0f33102c2bb206b5a7b3c929f7b5fcb50cb622c/bin/storm.cmd#L54
so it won't actually reach line 83
2) %STORM_LOGBACK_CONFIGURATION_FILE% this var pointing to logback.xml
 I added a new var STORM_LOGBACK_CLUSTER_CONF_FILE which is being passed to 
logviewer and other files . This var contains the location cluster.xml which 
contains the appenders and their config. 
  in storm.py  
https://github.com/apache/incubator-storm/blob/b0f33102c2bb206b5a7b3c929f7b5fcb50cb622c/bin/storm#L330
 we can keep one of these vars let me know which one you would prefer.




> Add support for logviewer in storm.cmd
> --------------------------------------
>
>                 Key: STORM-276
>                 URL: https://issues.apache.org/jira/browse/STORM-276
>             Project: Apache Storm (Incubating)
>          Issue Type: New Feature
>            Reporter: sriharsha chintalapani
>            Priority: Minor
>         Attachments: STORM-276.patch
>
>
> storm.cmd doesn't have logviewer functionality as it is in storm.py



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to