Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/61#discussion_r11351689
  
    --- Diff: storm-core/src/clj/backtype/storm/nimbus/leadership.clj ---
    @@ -0,0 +1,19 @@
    +(ns backtype.storm.nimbus.leadership
    +  (:import [backtype.storm.nimbus NimbusLeadership])
    +  (:use [backtype.storm log]))
    +
    +(defn nimbus-leadership [conf]
    +  (NimbusLeadership. conf))
    +
    +(defn get-nimbus-leader-address [conf]
    +  (.getNimbusLeaderAddress (nimbus-leadership conf)))
    +
    +(defn get-nimbus-hosts [conf]
    +  (.getNimbusHosts (nimbus-leadership conf)))
    --- End diff --
    
    We never call close on the nimbus-leadership.  I believe that we are 
leaking a connection to ZK every time this this and get-nimbus-leader-address 
is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to