Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/61#discussion_r11358486
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -894,10 +895,47 @@
)
)
+(defn- sync-storm-code-from-leader [nimbus]
--- End diff --
What happens if the standby nimbus has not downloaded everything when it
becomes the master? The current code relies on the topology to be scheduled
before the standby downloads anything. But there is a period of time between
when the topology is submitted successfully and when the topology is scheduled
where if nimbus goes down for whatever reason the topology will be killed.
This is probably OK to start out with, but would be nice to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
