Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/61#issuecomment-39755353
I have done a quick pass through the code. It looks like there are several
places that the code is leaking connections to ZK. I am also concerned about
the extra load that this may be placing on ZK. ZK is already the bottleneck
for scalability of the cluster, a new client connecting does a write operation
to the cluster, and having every client make a connection is bad, but not a
deal-breaker. However, also having the existing daemons constantly making new
connections to ZK feels like it will cause a lot of scalability issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
