GitHub user xpe opened a pull request:
https://github.com/apache/incubator-storm/pull/130
move towards idiomatic Clojure style
First, some background, when I first dig into a code base, I list to get a
rough idea what's inside by reading it over. I like to fix some obvious style
problems while I'm going along.
Summary:
* When using defn, put function arguments on a separate line.
* Remove dangling ),],}
* Try to keep lines at 80 characters or less
Going forward, Iâd like to see
* more docstrings
* most lines under 80 characters
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bluemont/incubator-storm idiomatic-clojure-01
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 2278fc9623d5b71bca9ece3857e645e85ab1562f
Author: David James <[email protected]>
Date: 2014-05-31T17:55:54Z
move towards idiomatic Clojure style
Summary:
* When using defn, put function arguments on a separate line.
* Remove dangling ),],}
* Try to keep lines at 80 characters or less
Going forward, Iâd like to see
* more docstrings
* most lines under 80 characters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
