Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/130#issuecomment-45087241
I like the idea of cleaning up the style of the clojure. For me I learned
clojure working on storm, and a lot of the code I write has fairly arbitrary
formatting. I have looked through some, but not all of the code and what I
have seen seems OK to me. I just really have a few concerns.
First is this somehow going to turn into a "religious" debate. I looked
around and could not find much of anything about formatting of clojure code,
except a stackoverflow saying format it like lisp. I couldn't find any
submission guidelines about it on clojure.org either. Is this just an
unwritten standard, or is there going to be a debate about this?
Second is there documentation anywhere that we can use to describe the
formatting? After doing something like this it seems logical to me that we
would want to try and have new pull requests also follow the same guidelines,
but we need something to point submitters to that they can use for this
purpose. Is there an automated tool that you used that can help with this
formatting as well?
My final concern is actually rather minor, but pulling this in is going to
cause some pair for anyone else who has a pull request outstanding, simply
because it touches so many different files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
