Github user knusbaum commented on the pull request:
https://github.com/apache/incubator-storm/pull/130#issuecomment-45167927
The only part I have a little concern about is the arguments on a separate
line of function defns.
I really prefer the argument lists to be on the same line as the
definition, since I find it more readable.
The style guides you proposed actually suggest that you include the
arguments on the same line unless there is a docstring, and I would really
prefer to follow that, rather than applying the rule indiscriminately.
That's my only request. I won't make a debate out of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
