[ 
https://issues.apache.org/jira/browse/STORM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026565#comment-14026565
 ] 

ASF GitHub Bot commented on STORM-338:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/130#discussion_r13599791
  
    --- Diff: DEVELOPER.md ---
    @@ -92,6 +92,14 @@ and
     [trivial 
issues](https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+STORM+AND+resolution+%3D+Unresolved+AND+priority+%3D+Trivial+ORDER+BY+key+DESC&mode=hide))
     because they require learning about only an isolated portion of the 
codebase and are a relatively small amount of work.
     
    +Please use idiomatic Clojure style, as explained in [this Clojure style 
guide][clj-SG]. Another useful reference is
    +the [Clojure Library Coding Standards][clj-LCS]. Perhaps the most 
important is consistenly writing a clear docstring
    --- End diff --
    
    consisten[t]ly (sorry)


> Move towards idiomatic Clojure style
> ------------------------------------
>
>                 Key: STORM-338
>                 URL: https://issues.apache.org/jira/browse/STORM-338
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: David James
>            Priority: Minor
>             Fix For: 0.9.2-incubating
>
>
> See discussion at https://github.com/apache/incubator-storm/pull/130
> To summarize my suggestion, can we go with these style and coding 
> recommendations?
> * http://dev.clojure.org/display/community/Library+Coding+Standards
> * https://github.com/bbatsov/clojure-style-guide



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to