[
https://issues.apache.org/jira/browse/STORM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026598#comment-14026598
]
ASF GitHub Bot commented on STORM-338:
--------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/130#issuecomment-45632088
Having code style standards is a good idea, and I'm for it.
* No objection to the style chosen.
* With this change, there is a git-blame "barrier." Say I am searching for
the revision a particular change was made: It seems to me I will hit this
commit for a large amount of the lines in the clojure source instead of
locating the commit where the last non-formatting change was made. Anyone know
a way around this or a better way of locating a commit for a particular line of
code?
* To practically help with compliance to this standard, is there an
automated tool we could use to validate changes or is it up to the reviewers to
manually do this?
* One tiny spelling comment
> Move towards idiomatic Clojure style
> ------------------------------------
>
> Key: STORM-338
> URL: https://issues.apache.org/jira/browse/STORM-338
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: David James
> Priority: Minor
> Fix For: 0.9.2-incubating
>
>
> See discussion at https://github.com/apache/incubator-storm/pull/130
> To summarize my suggestion, can we go with these style and coding
> recommendations?
> * http://dev.clojure.org/display/community/Library+Coding+Standards
> * https://github.com/bbatsov/clojure-style-guide
--
This message was sent by Atlassian JIRA
(v6.2#6252)
