[ 
https://issues.apache.org/jira/browse/STORM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026566#comment-14026566
 ] 

ASF GitHub Bot commented on STORM-338:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/130#discussion_r13599793
  
    --- Diff: conf/defaults.yaml ---
    @@ -94,6 +94,9 @@ supervisor.enable: true
     worker.childopts: "-Xmx768m"
     worker.heartbeat.frequency.secs: 1
     
    +# control how many worker receiver threads we need per worker 
    --- End diff --
    
    We have documentation in Config.java.  Do we want to duplicate it here?


> Move towards idiomatic Clojure style
> ------------------------------------
>
>                 Key: STORM-338
>                 URL: https://issues.apache.org/jira/browse/STORM-338
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: David James
>            Priority: Minor
>             Fix For: 0.9.2-incubating
>
>
> See discussion at https://github.com/apache/incubator-storm/pull/130
> To summarize my suggestion, can we go with these style and coding 
> recommendations?
> * http://dev.clojure.org/display/community/Library+Coding+Standards
> * https://github.com/bbatsov/clojure-style-guide



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to