Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/194#issuecomment-49171218
The retry seems OK to me. I only have two concerns.
The first one is that we are retrying for all RuntimeExceptions. I would
prefer to have us restrict the retry to just the case of the conflict. Curator
is already doing a lot of retries and in my experience if curator returns with
an error a retry is not going to help.
My second concern is with how quickly we are retrying. I suppose in the
common case we just got unlucky and downloaded the assignments in the middle of
nimbus updating. But retrying in a tight loop also does not feel correct. For
this one I am more interested in your and others opinions. I don't consider it
something that would block this from going in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
