Github user iwasakims commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/194#discussion_r15271391
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -67,12 +67,19 @@
[(Integer. port) (LocalAssignment. storm-id (doall
executors))]
))))
-
(defn- read-assignments
"Returns map from port to struct containing :storm-id and :executors"
- [assignments-snapshot assignment-id]
- (->> (dofor [sid (keys assignments-snapshot)] (read-my-executors
assignments-snapshot sid assignment-id))
- (apply merge-with (fn [& ignored] (throw-runtime "Should not have
multiple topologies assigned to one port")))))
+ ([assignments-snapshot assignment-id]
+ (->> (dofor [sid (keys assignments-snapshot)] (read-my-executors
assignments-snapshot sid assignment-id))
+ (apply merge-with (fn [& ignored] (throw-runtime "Should not
have multiple topologies assigned to one port")))))
+ ([assignments-snapshot assignment-id existing-assignment retries]
+ (try (let [assignments (read-assignments assignments-snapshot
assignment-id)]
+ (reset! retries 0)
+ assignments)
+ (catch RuntimeException e
+ (if (> @retries 2) (throw e) (swap! retries inc))
+ (log-warn (.getMessage e))
--- End diff --
Thanks for the comment. I updated the code. It shows the message like below
now:
```
19102 [nREPL-worker-0] INFO backtype.storm.daemon.nimbus - Setting new
assignment for topology id topology2-2-0:
#backtype.storm.daemon.common.Assignment{:master-code-dir
"/tmp/bd4c83e2-fcab-44e9-bfd9-678124f22a3f/nimbus/stormdist/topology2-2-0",
:node->host {"sup1" "centos63"}, :executor->node+port {[1] ["sup1" 1], [2]
["sup1" 2]}, :executor->start-time-secs {[1] 0, [2] 0}}
19196 [Thread-12] WARN backtype.storm.daemon.supervisor - Should not have
multiple topologies assigned to one port: retrying 1 of 3
19357 [nREPL-worker-0] INFO backtype.storm.daemon.nimbus - Delaying event
:do-rebalance for 0 secs for topology2-2-0
19372 [nREPL-worker-0] INFO backtype.storm.daemon.nimbus - Updated
topology2-2-0 with status {:type :rebalancing, :delay-secs 0, :old-status
{:type :active}, :num-workers nil, :executor-overrides {}}
19398 [Thread-12] WARN backtype.storm.daemon.supervisor - Should not have
multiple topologies assigned to one port: retrying 2 of 3
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
