[
https://issues.apache.org/jira/browse/STORM-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067585#comment-14067585
]
ASF GitHub Bot commented on STORM-87:
-------------------------------------
Github user xiaokang commented on the pull request:
https://github.com/apache/incubator-storm/pull/46#issuecomment-49514602
While checking the new exit-process! function, I find that it just use
log-message to generate an INFO level log. Is it more suitable to use
log-error? Since it should be some serious error to exit jvm.
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/util.clj#L317
(defn exit-process!
[val & msg]
(log-message "Halting process: " msg)
(.exit (Runtime/getRuntime) val))
> ShellBolt shoud fail fast on subprocess error
> ---------------------------------------------
>
> Key: STORM-87
> URL: https://issues.apache.org/jira/browse/STORM-87
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: James Xu
> Priority: Minor
>
> https://github.com/nathanmarz/storm/issues/542
> Now ShellBolt.die() just save the catched exception and throw it in next
> execute() call. If a tuple cause subprocess fail and next tuple received
> after some time, the ShellBolt will fail until next tuple. It maybe more
> useful to exit immediately in die().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
