[ 
https://issues.apache.org/jira/browse/STORM-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089404#comment-14089404
 ] 

ASF GitHub Bot commented on STORM-87:
-------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/46#issuecomment-51496090
  
    +1 it looks good to me. I know @d2r is out for a few days and the changes 
are so small that I feel fine merging it in now.  


> ShellBolt shoud fail fast on subprocess error
> ---------------------------------------------
>
>                 Key: STORM-87
>                 URL: https://issues.apache.org/jira/browse/STORM-87
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: James Xu
>            Priority: Minor
>
> https://github.com/nathanmarz/storm/issues/542
> Now ShellBolt.die() just save the catched exception and throw it in next 
> execute() call. If a tuple cause subprocess fail and next tuple received 
> after some time, the ShellBolt will fail until next tuple. It maybe more 
> useful to exit immediately in die().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to