[
https://issues.apache.org/jira/browse/STORM-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089057#comment-14089057
]
ASF GitHub Bot commented on STORM-87:
-------------------------------------
Github user dashengju commented on the pull request:
https://github.com/apache/incubator-storm/pull/46#issuecomment-51449711
@xiaokang
I found a problem with the current die() function describe in
https://github.com/apache/incubator-storm/pull/218 , and I think your PR will
resolve the problem, but this PR is based old code and you did not modify in
ShellSpout, so I copy your code to the new PR.
if you change the code in this PR to solve STORM-442, I will close my PR.
> ShellBolt shoud fail fast on subprocess error
> ---------------------------------------------
>
> Key: STORM-87
> URL: https://issues.apache.org/jira/browse/STORM-87
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: James Xu
> Priority: Minor
>
> https://github.com/nathanmarz/storm/issues/542
> Now ShellBolt.die() just save the catched exception and throw it in next
> execute() call. If a tuple cause subprocess fail and next tuple received
> after some time, the ShellBolt will fail until next tuple. It maybe more
> useful to exit immediately in die().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
