GitHub user kishorvpatil opened a pull request:
https://github.com/apache/incubator-storm/pull/220
[STORM-330] Implement storm exponential backoff stategy for netty client
and curator
Fix [netty
Client.java](storm-core/src/jvm/backtype/storm/messaging/netty/Client.java)
retry logic and [Utils.java](storm-core/src/jvm/backtype/storm/utils/Utils.java
) Curator Framework.
The `StormBoundedExponentialBackoffRetry` provides generic
exponential-linear backoff retry policy for STORM. It overcomes the following
shortcomings in curator frameworks implementation of
`BoundedExponentialBackOffRetry`:
- Limitation maxRetries to 29.
- `getSleepTimeMs` fails with IllegalArgumentException by passing -ve
argument to random.nextInt if retryCount > 29.
- Also, exponential calculation in quickly catches up to `maxSleepTimeMs`
- eventually adding more delay and increasing collision possibility.
This class calculates `threshold` for exponentially increasing `sleeptime`
for retries. Beyond threshold, the sleep time increase is linear.
It adds jitter for exponential/linear retry.
It guarantees `currSleepTimeMs >= prevSleepTimeMs` and `baseSleepTimeMs <=
currSleepTimeMs <= maxSleepTimeMs`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm
storm-backoff-retry-strategy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #220
----
commit 7d21ffe9f9f61c9e3115add26a250b95084b131d
Author: Kishor Patil <[email protected]>
Date: 2014-08-08T20:32:20Z
Implement storm exponential backoff stategy to use for netty client and
curator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
