Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/220#issuecomment-53676020
@revans2,
I have addressed all the concerns and all tests pass now.
- `backtype.storm.utils-test test-new-curator-uses-exponential-backoff`
exposed `getMaxRetryInterval` for testing alone. Since the `maxRetryInterval`
is argument passed in constructor and need not again be retrieved for assertion
against what was passed to the constructor.
- About failing tests, the constructor arguments needed to be corrected,
since old class had different order of `maxRetries` and `maxSleepTimeMs` in
`Utils.java`.
- About `divide by zero`, was scenarios I overlooked - when `maxRetries`
is below `expRetriesThreshold`, making the RetryPolicy - exponential only. In
that case, the calculation of `linearBaseSleepMs` failed. Now I am forcing it
to `1` whenever user configures `maxRetries` below exponential retry threshold.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
