Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/220#discussion_r16061121
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -137,8 +138,9 @@ private synchronized void connect() {
if (channel != null && channel.isConnected()) {
return;
}
-
+
int tried = 0;
+ StormBoundedExponentialBackoffRetry retryPolicy = new
StormBoundedExponentialBackoffRetry(base_sleep_ms, max_sleep_ms, max_retries);
--- End diff --
Would it make sense to make `retryPolicy` an instance variable and
instantiate it in the constructor rather than create a new one for every call
to `connect()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
