[
https://issues.apache.org/jira/browse/STORM-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093172#comment-14093172
]
ASF GitHub Bot commented on STORM-449:
--------------------------------------
GitHub user revans2 opened a pull request:
https://github.com/apache/incubator-storm/pull/223
STORM-449: Updated ShellBolt to not exit when shutting down.
I modified the test that was having issues to run 100 times in a row.
Previously it would fail after 1 or 2 times through the loop. Now it passes
all of the times no problem. I didn't include the test change because it is
overkill here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit ee86ad9b6963722a2f2d91c04d5014c11c0a9024
Author: Robert (Bobby) Evans <[email protected]>
Date: 2014-08-11T18:59:08Z
Updated ShellBolt to not exit when shutting down.
----
> ShellBolt can cause periodic test failures
> ------------------------------------------
>
> Key: STORM-449
> URL: https://issues.apache.org/jira/browse/STORM-449
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Fix For: 0.9.3-incubating
>
>
> The shell metrics tests fail every so often because of a race in shutting
> down. The ShellBolt will call System.exit on errors now, but during shutdown
> we can kill the process before stopping the reader thread. This is not
> ideal. We shouldn't exit when shutign down in general and we should
> interrupt the reader thread before we kill the process.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
