[ 
https://issues.apache.org/jira/browse/STORM-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104226#comment-14104226
 ] 

ASF GitHub Bot commented on STORM-449:
--------------------------------------

Github user ptgoetz commented on the pull request:

    https://github.com/apache/incubator-storm/pull/223#issuecomment-52815733
  
    +1


> ShellBolt can cause periodic test failures
> ------------------------------------------
>
>                 Key: STORM-449
>                 URL: https://issues.apache.org/jira/browse/STORM-449
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.9.3-incubating
>
>
> The shell metrics tests fail every so often because of a race in shutting 
> down.  The ShellBolt will call System.exit on errors now, but during shutdown 
> we can kill the process before stopping the reader thread.  This is not 
> ideal.  We shouldn't exit when shutign down in general and we should 
> interrupt the reader thread before we kill the process.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to