[
https://issues.apache.org/jira/browse/STORM-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102598#comment-14102598
]
ASF GitHub Bot commented on STORM-449:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/223#discussion_r16433290
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -293,11 +295,13 @@ private void handleMetrics(ShellMsg shellMsg) {
}
private void die(Throwable exception) {
- String processInfo = _process.getProcessInfoString() +
_process.getProcessTerminationInfoString();
- _exception = new RuntimeException(processInfo, exception);
- LOG.error("Halting process: ShellBolt died.", exception);
- _collector.reportError(exception);
- System.exit(11);
+ if (_running) { //Don't exit if running tests
--- End diff --
Let's change the comment to me non-specific to tests. If we aren't
running, don't bother.
> ShellBolt can cause periodic test failures
> ------------------------------------------
>
> Key: STORM-449
> URL: https://issues.apache.org/jira/browse/STORM-449
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Fix For: 0.9.3-incubating
>
>
> The shell metrics tests fail every so often because of a race in shutting
> down. The ShellBolt will call System.exit on errors now, but during shutdown
> we can kill the process before stopping the reader thread. This is not
> ideal. We shouldn't exit when shutign down in general and we should
> interrupt the reader thread before we kill the process.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
