Matt, 

Could you share the commands you ran that demonstrated the test failure and 
I’ll try to replicate?

There were problems in that module/test until a few months ago, I had thought 
they were cleared up by 
https://github.com/apache/incubator-streams/pull/349/files and 
https://builds.apache.org/job/streams-project has been blue for some time.
On March 7, 2017 at 8:50:05 AM, Matt Franklin (m.ben.frank...@gmail.com) wrote:

+0 (binding)  

I found a test that consistently fails under Ubuntu linux, but the same  
test passes on OSX. SchemaOrderingTest.compareUnrelated. I haven't looked  
into it yet, but likely something environmental is impacting the ordering,  
such as the file system. We *could* put the release out with a note, but  
IMO, it would be better to cut a new release candidate after it is fixed.  

On Mon, Mar 6, 2017 at 12:31 PM sblackmon <sblack...@apache.org> wrote:  


Ate,  

Thanks for the +1. Responses in-line below.  

Steve  

On March 5, 2017 at 5:13:00 PM, Ate Douma (a...@douma.nu(mailto:a...@douma.nu)) 
 
wrote:  

> +1 (binding) on the 0.5 RC1 release.  
>  
> I've verified the sources and deployed nexus artifacts on license, notice  
and  
> disclaimer files and license headers.  
> I didn't verify the build myself, but as enough others already did, I'm  
> trusting it works fine.  
>  
> It would be good if the current site would be updated/fixed with regards  
to the  
> new combined streams-master and streams-project, as well as the build  
> instructions for it, as this is now in a confusing state.  

True. We have STREAMS-486 open for this purpose, tagged for 0.5-incubating  
sprint. Not a problem to take care of this when we update the webpage with  
the links to download 0.5-incubating.  

>  
>  
> And I still think it would be better if the example modules which do *not*  
> have an artifactId not prefixed with "streams-" are updated to use such  
prefix.  
>  
> Now there are for example the flink-twitter-collection-0.5-incubating,  
> google-gplus-0.5-incubating, etc. modules (6 modules in total) which  
produce  
> artifacts that IMO are confusing for downstream users what originating  
project  
> they 'belong' to.  
> And as result their embedded NOTICE and DISCLAIMER files contain a  
confusing  
> (generated) statement like:  
>  
> google-gplus  
> Copyright 2017 The Apache Software Foundation  
>  
> By correcting the artifactIds to for example  
streams-provider-google-gplus this  
> would yield the more clear/correct:  
>  
> streams-provider-google-gplus  
> Copyright 2017 The Apache Software Foundation  
>  
> I really think this can and should be fixed before the 0.6 release and/or  
> streams graduation.  

That’s a good point. In 0.5-incubating we closed STREAMS-463 which  
addressed a similar concern with package naming, but I agree we should do  
so for artifact naming as well.  

Opened STREAMS-497, tagged as fixVersion 0.6 and placed in sprint 0.6.0  
along with a few other known issues which might reasonably be a blocker to  
graduation.  

>  
>  
> Regards, Ate  
>  
> On 2017-03-03 21:13, Matt Franklin wrote:  
> > Apologies for the e-mail issues. It was pointed out that the key on  
> > people.apache.org has not been updated yet. Until then, the correct key  
is  
> > located here:  
> >  
> > https://dist.apache.org/repos/dist/release/incubator/streams/KEYS  
> >  
> > I have also fixed the URLs to the source packages inline.  
> >  
> > On Fri, Mar 3, 2017 at 2:45 PM Matt Franklin  
> > wrote:  
> >  
> >> A couple of URL tweaks.  
> >>  
> >> On Fri, Mar 3, 2017 at 2:35 PM Matt Franklin  
> >> wrote:  
> >>  
> >> I've created a combined 0.5-incubating release candidate (rc1), with  
the  
> >> following artifacts up for a vote:  
> >>  
> >> *** NOTE ***  
> >> This is the first release of streams with the combined  
incubator-streams  
> >> and master projects.  
> >>  
> >> Tags  
> >> =========================================  
> >> incubator-streams source tag (r0.5-incubating):  
> >> *  
https://git-wip-us.apache.org/repos/asf?p=incubator-streams.git;a=tag;h=c56bfa9e060e2ff4e2b19704e0053de7f2fa325b
  
> >> *  
> >>  
> >> incubator-streams-examples source tag (r0.5-incubating):  
> >>  
> >>  
https://git-wip-us.apache.org/repos/asf?p=incubator-streams-examples.git;a=tag;h=2cf40517cd93654db3ec90f853d4db2aaab90790
  
> >>  
> >> Maven staging repo  
> >> ==========================================  
> >> https://repository.apache.org/content/repositories/orgapachestreams-10  
> >>  
> >> 24  
> >>  
> >>  
> >>  
https://repository.apache.org/content/repositories/orgapachestreams-1024  
> >>  
> >>  
> >>  
> >> Source releases:  
> >> ==========================================  
> >> incubator-streams  
> >>  
> >>  
https://dist.apache.org/repos/dist/dev/incubator/streams/0.5-incubating/streams-examples-0.5-incubating-source-release.zip
  
> >> SHA1: a3512225b06eeda6f4551cd89ce9faa55a4fc1ea  
> >>  
> >>  
> >  
https://dist.apache.org/repos/dist/dev/incubator/streams/0.5-incubating/streams-project-0.5-incubating-source-release.zip
  
> >  
> >  
> >>  
> >> incubator-streams-examples  
> >>  
> >>  
https://dist.apache.org/repos/dist/dev/incubator/streams/0.5-incubating/streams-project-0.5-incubating-source-release.zip
  
> >> SHA1: ca91ccaad4e53dee387b311679cb1beb73ae54a0  
> >>  
> >>  
> >  
https://dist.apache.org/repos/dist/dev/incubator/streams/0.5-incubating/streams-examples-0.5-incubating-source-release.zip
  
> >  
> >  
> >> Release artifacts are signed with the following key:  
> >> *https://people.apache.org/keys/committer/mfranklin.asc  
> >> *c  
> >>  
> >>  
> >>  
> >> https://people.apache.org/keys/committer/mfranklin.asc  
> >>  
> >>  
> >>  
> >>  
> >> Please take the time to verify these artifacts before casting your  
vote.  
> >>  
> >> Note that Maven 3.3.9 and JDK 1.8+ are now required, and that  
MAVEN_OPTS  
> >> should set the java heap to at least 2G for best results.  
> >>  
> >> These repositories must be built and installed locally in the right  
order:  
> >> first streams-project, then streams-examples.  
> >>  
> >> Note that to execute the full suite of integration tests, one must  
first  
> >> prepare a testing environment with docker databases and working  
credentials  
> >> to all providers.  
> >>  
> >> Vote will be open for 72 hours.  
> >>  
> >> [ ] +1 approve  
> >> [ ] +0 no opinion  
> >> [ ] -1 disapprove (and reason why)  
> >>  
> >>  
> >  
>  

Reply via email to