To me, the question comes down to do you want to put the burden of reformatting code (even if it amounts to a click of a button) on committers rather than those submitting patches?
I know with JWP, I ask that anyone submitting patches follow the general coding standards the existing code uses, as "enforced" by the CheckStyle rules file. Yes, I would fix things myself before a commit, I would never turn down a patch for non-compliance to formatting rules, but it's still nice to get them in a compliant form. It was actually put best by another JWP committer who said to me "when I go over someones' house to play, I do my best to play by their rules, even if all they are going to do is politely correct me". So, do you want to be the parent that has to correct someone, or do you want to make it as easy as possible (and universal, which is more to the point in this case) to follow the rules? If you make IDEA *the* way to reformat the code, your shifting the burden from anyone who wants to contribute (and who doesn't themselves have IDEA) to the committers to do the reformatting. I'm not trying to be difficult, just trying to point out the consequence of the decision, assuming it goes that way. If everyone is OK with it, I'm certainly OK with it too as I'm not in a position to have any reason to complain :) Hell, in fact, now I don't have to even think about code formatting when I submit a patch, so less work for me! :) -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com AIM: fzammetti Yahoo: fzammetti MSN: [EMAIL PROTECTED] On Wed, January 18, 2006 1:30 pm, Ted Husted said: > On 1/18/06, Laurie Harper <[EMAIL PROTECTED]> wrote: >> If the goal is to be able to run a tool to get checkstyle 'conformance' >> wouldn't it be better to tailer checkstyle to a tool anyone could grab, >> rather than tailoring it to what IDEA can do? Don't get me wrong, I love >> IDEA and I'd be quite happy to be able to use it for this, but not >> everyone has IDEA... >> >> +1 in principle, though. > > Jetbrains has donated licenses for the use of any and all ASF > committers, so anyone with write privilges can indeed grab IDEA and > use it to reformat the code on demand. Moreover, the reformatter is > very clever and doesn't "touch" files that do not need reformatting. > Any one can bring the codebase up to date in a matter of seconds > (literally) and commit back on the files that needed style fixes. The > important thing would be to continue to follow the longstanding rule > to separate style-change commnits from code-change commits. > > As I understand, WebWork 2.2 is styled using the factory-default IDEA > settings. If we want that codebase to pass CheckStyle in the future, > eventually, we will need to conform one or the other. > > But, yes, I'm thinking that it might be less work to conform > CheckStyle to IDEA than the other way around. The goal should be to > ensure that a uniform coding style is consistently applied. > > -Ted. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
