On 5/11/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:
On 5/11/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: > I have taken some time to check out the 1.3.4 version today - > upgrading my webapp to this version (was on 1.2.9) and the only other > issue(s) I came up with is that we used to distribute things like the > validator-rules.xml config and taglib tlds in the lib directory. I > releaize that these are now all packaged in the jar and the distro > does include the source - but I expect quite a few people will still > have these manually configured and will have difficulty finding them > in the distro. First, thank you for taking the time to review 1.3.4. I really appreciate it. I thought about including those resources, and decided against it. They were not in the 1.3.0 'lib' distribution, either. I'm willing to answer the questions on the user list, and I think we should encourage people to configure their apps to use the latest versions of the resources that we've provided in the jar files.
+1 on the recommended configuration approach (use the canonical URLs instead of references to explicit resources in WEB-INF). Since we now require Servlet 2.3, there's little reason to configure
tlds in web.xml, and there's no reason to keep a copy of validator-rules.xml in WEB-INF when it can be loaded from struts-core.jar. We can include them in 'lib' in the next distribution if more people disagree. (But as you pointed out, they are included with the source.)
I think we should include the DTDs in some convenient place like "lib" in the distro in *addition* to the previous comments on recommended configuration practices. There's lots of documentation about valid options in the DTD documents themselves that is not reproduced anywhere else. It should be as easy as possible to get to these files for *reading* them, not just for using them in an app. Craig
