Here is a JIRA tag to catch several other bugs (including two marked
resolved when they were not). The patch file is included with the
ticket!
Please let me know how it goes. I have only minimally tested
velocity, but have tested the FreeMarker side extensively. I am
throwing the plugin on two of my production servers to see how it
handles a load. Unfortunately they are both FreeMarker decorator
apps...
-- Christian Stone
Update sitemesh-plugin to use version 2.4.2. (CLONE, CATCHALL).
----------------------------------------------------------------
Key: WW-3291
URL: https://issues.apache.org/struts/browse/WW-3291
Project: Struts 2
Issue Type: Bug
Components: Plugin - SiteMesh
Affects Versions: 2.1.8, 2.1.6
Environment: JDK 1.5+, Struts 2.1.6+ & SiteMesh 2.4+
Reporter: Christian Wolfgang Stone
Priority: Critical
Catch-all bug for the following bugs: WW-3116 (marked as resolved,
not fixed), WW-1128 (should now work on 2.4 and lower), WW-3275
(very good description),
Detailed description of this issue can be found in the following
discussion thread.
http://www.nabble.com/Struts-2.1.8-%2B-SiteMesh-2.4.2-%2B-FreeMarkerPageFilter-Broken-td25721587.html
I am attaching a patch that updates the struts2-sitemesh plugin to use
the more current SiteMeshPageFilter.java class. The old code was
deprecated and deleted from the sitemesh with the 2.4.2 release!
The new files are as follows. I am testing the freemarker
extensively, and will test the velocity a bit later. Please test both
and let me know if there are any problems.
FreeMarkerMapper2DecoratorSelector.java
OldDecorator2NewStrutsDecorator.java
VelocityMapper2DecoratorSelector.java
FreeMarkerPageFilter.java
OldDecorator2NewStrutsFreemarkerDecorator.java VelocityPageFilter.java
NoneDecoratorMapper.java
OldDecorator2NewStrutsVelocityDecorator.java
On Oct 21, 2009, at 6:20 AM, Wes Wannemacher wrote:
We can't take a jar, create a patch from your modified sources and
attach it to the jira issue related to upgrading sitemesh. One of us
will take a look at the failing test if you don't figure it out.
-Wes
--
_,--"
cws `-._ ________-_______ "----
_----'--'--------------------------------'--'----_
//_| | \ Christian Stone, Software Engineer / | |_\\
(_____|_|__= xt...@stonescape.net =__|_|_____)
_\_____=__ http://xtian.stonescape.net/ ___/_
\/-(o)-~~-(o)-~~-(o)-`------'-(o)-~~-(o)-~~-(o)-\/
