Hello Łukasz (and Struts Dev Team).

     Sorry for the long response (I was trying to be thorough).  :)

     I checked out tag STRUTS_2_5_23 and built it locally with JDK7, as you 
suggested.  It produced the same January 5 2020 modification timestamps inside 
all the zip files produced by the assembly.

     Next I examined some other recent 2.5.x project builds assembly zip files 
from June 2020, and they also have the January 5 2020 modification timestamped 
contents.

     Checking a recent JDK8-built 2.6.0 project build from June 2020 showed it 
also had the weird January 2020 modification timestamps for its contents.  It 
looks like both 2.5.x and 2.6.x builds are affected the same way.  :(

     After that, checking a recent 2.3.38-SNAPSHOT build (July 2020) showed 
that its zip file contents were normal (modification content timestamps in July 
2020).

     With some digging and comparing maven-assembly-plugin versions for the 
2.3.38 vs. 2.5.23 builds it looks like the Maven Assembly Plugin is somehow 
involved in the issue.

     Overriding the maven-assembly-plugin versions in the Struts 2 Assembly the 
results were:
     - The assembly build produces good zip-content modification timestamps for 
plugin: 2.6.0, 3.0.0 and 3.1.1.
     - The assembly build produces bad zip-content modification timestamps for 
plugin: 3.2.0, 3.3.0.
       For 2.5.23 the Maven build uses maven-assembly-plugin 3.2.0 (did not 
check 2.6).

     So the zip incorrect content modification timestamp issues could be a 
Maven Assembly Plugin bug affecting more recent versions (v3.2.0+) ?

     I did a really quick search for a relevant JIRA on this but did not find 
one.  If anyone knows of a JIRA or has seen a similar symptom, please advise.  

     What to you think ?  Should the Struts 2 Assembly POM override the 
maven-assembly-plugin version in the build(s) to 3.1.1 for now ?

Regards,

     James.


On 2020/07/07 07:23:11, Lukasz Lenart <lukaszlen...@apache.org> wrote: 
> wt., 7 lip 2020 o 08:03 Lukasz Lenart <lukaszlen...@apache.org> napisał(a):
> > I have no idea how this could happen, I checked the files from
> > assembly/target locally and they are the same, January 5th :\ Let me
> > drop this test build and I will start over.
> 
> I gave up, wiped out the whole ~/.m2/repository and started over, used
> "mvn" and "./mvnw" also upgraded Maven Assembly Plugin to 3.3.0 and
> still the same. Used also the "tar.gz" format and the folders have a
> proper date (today) but files are changed.
> 
> It looks like Zip is the cause  but I have no idea why.
> 
> Could you checkout the tag STRUTS_2_5_23 and run "mvn clean package"
> using JDK7 if possible? in assembly/target/assembly/out you should get
> the Zips
> 
> 
> Regards
> -- 
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to