Hi! [[[ When updating to loose an external the code should handle a locally missing externals item.
* subversion/tests/cmdline/externals_tests.py (update_loose_external): Remove one externals wc dir. ]]] I'm writing a patch to remove some adm_access batons. That patch made the externals_tests even though it didn't handle missing local externals which trunk does. Why should we handle a locally missing externals here? The user might have thought that the externals items should be removed manually after beeing removed from the property. Users do strange things. Handle it gracefully! I thought the change was so small that it could be included in an existing test case. Daniel
Index: subversion/tests/cmdline/externals_tests.py =================================================================== --- subversion/tests/cmdline/externals_tests.py (revision 887852) +++ subversion/tests/cmdline/externals_tests.py (arbetskopia) @@ -398,6 +398,10 @@ # Set and commit the property change_external(os.path.join(wc_dir, "A/D"), new_externals_desc) + # The code should handle a missing local externals item + svntest.main.safe_rmtree(os.path.join(other_wc_dir, "A", "D", "exdir_A", \ + "D")) + # Update other working copy, see if lose & preserve things appropriately svntest.actions.run_and_verify_svn(None, None, [], 'up', other_wc_dir)
