On Mon, Dec 07, 2009 at 10:03:12AM +0000, Julian Foad wrote: > Philip Martin wrote: > > Daniel Näslund <dan...@longitudo.com> writes: > > > > > When updating to loose an external the code should handle a locally > > > missing externals item. > > I edited that part of the log message to make clear what the patch is > for: > > [[[ > When updating to lose an external, the code should handle a locally missing > externals item, and it does. Add a test for this in an existing test case. > ]]] > > - Julian > > > > > * subversion/tests/cmdline/externals_tests.py > > > (update_loose_external): Remove one externals wc dir. > > > ]]] > > > > > > I'm writing a patch to remove some adm_access batons. That patch made > > > the externals_tests even though it didn't handle missing local > > > externals which trunk does. > > > > I don't understand that last sentence, did you miss out a word, pass > > or fail perhaps? > > > > Anyway, it's a sensible extension to the test. r887867, thanks! > >
Thanks Julian and Philip! Writing code is easy, explaining what it does in english is the hard part. :-)