Daniel Shahaf wrote: > [...] I think striking the word(s) "third-party" from your third > paragraph will not affect its correctness. > > Greg Stein wrote: >> IOW, when we release an Ev2-based Subversion, and third-party clients >> that were built against the 1.0 through 1.7 APIs... those clients will >> have shims inserted, and lose the check. [...]
So... Greg's talking about if a <= 1.7 client is re-linked against the Ev2-capable libraries, the shims would be inserted and that check would be lost. But what happens if, instead, we run that <= 1.7 client *with its old libraries* and connect to an Ev2-capable server? Then the shims would not be used on the client side; instead the server would talk Ev1 protocol ... but then the Ev2 -> Ev1 shims would be used on the server side to drive the old Ev1 protocol ... and so the base checksum would still be set to null, thus bypassing apply_textdelta's check, would it not? - Julian
