+1 on that creating localized strings from such small strings is not the right way.
Bert -----Original Message----- From: "Branko Čibej" <br...@wandisco.com> Sent: 19-8-2013 09:50 To: "dev@subversion.apache.org" <dev@subversion.apache.org> Subject: Re: svn commit: r1515023 - /subversion/branches/1.8.x/STATUS On 19.08.2013 08:45, Ben Reser wrote: > On Sun Aug 18 18:23:17 2013, Ivan Zhakov wrote: >> Do we localize commas in current code? (I do not have source code >> acces now) > Not that I'm aware of but I can say that '%s' is turned into »%s« in > German. Branko has already given an example of a locale where commas > would be changed. I see no reason not to do this the right way now. It was Daniel actually. And yes, we do localize commas, there are any number of translated messages with commas (or colons) in them. And you don't have to go very far afield to find a locale where ": " would not translate to two bytes; IIRC Spanish requires a space before the colon, making it " : ". I do have to say however that the way we assume sentence structure in that code is going to give translators headaches (again). It is always wrong to construct sentences from smaller pieces, even if those pieces themselves are translated. -- Brane -- Branko Čibej | Director of Subversion WANdisco // Non-Stop Data e. br...@wandisco.com
