Daniel Sahlberg wrote on Mon, 01 Feb 2021 21:21 +00:00:
> Den tors 21 jan. 2021 kl 17:58 skrev Daniel Sahlberg 
> <daniel.l.sahlb...@gmail.com>:
> > Den tors 21 jan. 2021 17:16Daniel Shahaf <d...@daniel.shahaf.name> skrev:
> >> If there's a way to make that work without requiring javascript, that'd
> >> be great.  If nothing else, presetting the textbox's value to
> >> "inurl:subversion" and then removing that in javascript unconditionally
> >> might work?
> > 
> > I'm not a web designer, never will be. But according to my searches the 
> > inurl has to be part of the search string, it can't be passed as a separate 
> > field in the query string. I'd be happy if I'm proven wrong. 
> > 
> > I think it will confuse users to have it as a predefined value in the input 
> > box. A possible solution would be to have it in the html file, remove it 
> > with javascript when the document is loaded and the adding it again on 
> > submit. That way it would work for user without javascript (with a slight 
> > inconvenience) as well. But how many is that really these days?
> 
> Finally found some time to look at this again. I've committed r1886109 which:
> * Add inurl:subversion as the default value to the textbox.
> * Remove it in body.onload.
> * Add it again when the form is submitted.
> 
> The last two obviously only happen to users with javascript enabled.
> 
> Feel free to test it at 
> https://subversion-staging.apache.org/mailing-lists.html

+1, thanks a lot!

Daniel

Reply via email to