williaster commented on a change in pull request #4566: Adding column type
label to dropdowns
URL:
https://github.com/apache/incubator-superset/pull/4566#discussion_r173588482
##########
File path: superset/assets/spec/javascripts/components/ColumnTypeLabel_spec.jsx
##########
@@ -0,0 +1,62 @@
+import React from 'react';
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { shallow } from 'enzyme';
+
+import ColumnTypeLabel from '../../../javascripts/components/ColumnTypeLabel';
+
+describe('ColumnOption', () => {
+ const defaultProps = {
+ type: 'string',
+ };
+
+ let wrapper;
+ let props;
+ const factory = o => <ColumnTypeLabel {...o} />;
Review comment:
I know there are a lot of places that do this already, but single character
variable names don't facilitate readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
