[ 
https://issues.apache.org/jira/browse/SYNCOPE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313849#comment-15313849
 ] 

ASF GitHub Bot commented on SYNCOPE-866:
----------------------------------------

Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/18#discussion_r65673151
  
    --- Diff: 
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/KeyAlreadyExistsException.java
 ---
    @@ -0,0 +1,35 @@
    +/*
    --- End diff --
    
    This class is not needed, please remove and use instead 
`org.apache.syncope.core.persistence.api.dao.DuplicateException` (see above).


> Check for existence of key before adding template
> -------------------------------------------------
>
>                 Key: SYNCOPE-866
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-866
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tushar Mishra
>             Fix For: 2.0.0
>
>
> The create(String key) method in the MailTemplateLogic and 
> ReportTemplateLogic classes of the org.apache.syncope.core.logic package 
> should check if the key being added to the MailTemplateDAO instance is 
> already present. If such a key already exists, it should throw an appropriate 
> exception for the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to