[ 
https://issues.apache.org/jira/browse/SYNCOPE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313858#comment-15313858
 ] 

ASF GitHub Bot commented on SYNCOPE-866:
----------------------------------------

Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/18
  
    Thanks for this PR @tmess567, I appreciate it very much.
    I have added some comments to avoid duplicate classes and stay close to 
what other Logic classes do.
    
    Please fix with an additional commit.
    Thank you very much.


> Check for existence of key before adding template
> -------------------------------------------------
>
>                 Key: SYNCOPE-866
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-866
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tushar Mishra
>             Fix For: 2.0.0
>
>
> The create(String key) method in the MailTemplateLogic and 
> ReportTemplateLogic classes of the org.apache.syncope.core.logic package 
> should check if the key being added to the MailTemplateDAO instance is 
> already present. If such a key already exists, it should throw an appropriate 
> exception for the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to