[ https://issues.apache.org/jira/browse/SYNCOPE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314055#comment-15314055 ]
ASF GitHub Bot commented on SYNCOPE-866: ---------------------------------------- Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/18 LGTM, please squash your three commits into one, and don't forget to mention SYNCOPE-866 in the final commit log (the very first used here will work, anyway). I will merge this PR at earliest next Monday 6th, after that the freeze period due to the ongoing release VOTE is over. > Check for existence of key before adding template > ------------------------------------------------- > > Key: SYNCOPE-866 > URL: https://issues.apache.org/jira/browse/SYNCOPE-866 > Project: Syncope > Issue Type: Improvement > Components: core > Reporter: Tushar Mishra > Fix For: 2.0.0 > > > The create(String key) method in the MailTemplateLogic and > ReportTemplateLogic classes of the org.apache.syncope.core.logic package > should check if the key being added to the MailTemplateDAO instance is > already present. If such a key already exists, it should throw an appropriate > exception for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)