ilgrosso commented on code in PR #1278: URL: https://github.com/apache/syncope/pull/1278#discussion_r2657907651
########## client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties: ########## @@ -33,3 +33,7 @@ endDelegation=End Delegation sessionExpiration.header=Session Expiration sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working. sessionExpiration.extend=Extend + Review Comment: The menu is shown by all pages, which are all inheriting from `BasPage`, that's why putting the label in `BasePage*.properties` works. You can't put it in `Topology*.properties` because otherwise all other pages will not know how to translate the Topology label. There should be a way to move the translations with their own module, especially considering ext pages, which are currently not included in this PR but need to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
