massx1 commented on code in PR #1278: URL: https://github.com/apache/syncope/pull/1278#discussion_r2658029083
########## client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties: ########## @@ -33,3 +33,7 @@ endDelegation=End Delegation sessionExpiration.header=Session Expiration sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working. sessionExpiration.extend=Extend + Review Comment: I used the BasePage.properties file otherwise, the localized label would be visible only on the selected page. For example, the Home page would show the default label, while the Topology page would show the localized label. I think using BasePage is also a logical choice, since we are referring to the menu. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
