ilgrosso commented on code in PR #1278: URL: https://github.com/apache/syncope/pull/1278#discussion_r2658037164
########## client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties: ########## @@ -33,3 +33,7 @@ endDelegation=End Delegation sessionExpiration.header=Session Expiration sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working. sessionExpiration.extend=Extend + Review Comment: Maybe you can have a look at [Wicket docs](https://nightlies.apache.org/wicket/guide/10.x/single.html#_internationalization_with_wicket) and come up with something that actually solves a general issue rather than just enabling the translation of `Topology` - because this is all that this PR seems to be about, while there is actually room for some serious improvement. Summarizing: 1. come up with a solution which allows to plug-in translations for page menu items, whether such pages are idm, am or ext 2. find a way to leave the labels in the same source module where the page is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
