TatoniMatteo commented on code in PR #1580:
URL: https://github.com/apache/syncope/pull/1580#discussion_r4325247835
##########
client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java:
##########
@@ -378,10 +354,10 @@ public String getObject(
if (jexlHelp) {
AjaxTextFieldPanel.class.cast(panel).enableJexlHelp();
}
+ }
- if (required) {
- panel.addRequiredLabel();
- }
+ if (required) {
Review Comment:
I made this change because all panels handle `required` in the same way,
except for the old AjaxCheckboxPanel.
With the new component, boolean fields would also handle `required`
consistently with the other panels, so I think we can align the behavior this
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
