TatoniMatteo commented on code in PR #1580:
URL: https://github.com/apache/syncope/pull/1580#discussion_r4325311734
##########
client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java:
##########
@@ -378,10 +354,10 @@ public String getObject(
if (jexlHelp) {
AjaxTextFieldPanel.class.cast(panel).enableJexlHelp();
}
+ }
- if (required) {
- panel.addRequiredLabel();
- }
+ if (required) {
Review Comment:
The new component handles both `Boolean` and `boolean` (`required=true`).
When the field is required, the component no longer displays the middle
`unset` button, leaving only `true` and `false` options.
In `BeanPanel`, I kept the behavior you described (`Boolean` ->
`TriStateButton`, `boolean` -> `checkbox`), while in all other cases I
completely replaced the old component with the new one and set `required`
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
