TatoniMatteo commented on code in PR #1580:
URL: https://github.com/apache/syncope/pull/1580#discussion_r4325395817
##########
client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java:
##########
@@ -378,10 +354,10 @@ public String getObject(
if (jexlHelp) {
AjaxTextFieldPanel.class.cast(panel).enableJexlHelp();
}
+ }
- if (required) {
- panel.addRequiredLabel();
- }
+ if (required) {
Review Comment:
Not exactly. I haven't replaced `AjaxCheckboxPanel` throughout the entire
project, as there are places where a simple checkbox is more appropriate than a
more complex component like this one (in my opinion). So far, I've introduced
it in the edit modals for `User`, `AnyObject`, and `Realm`, in the
`UserRequest` form, in the attribute form in `Enduser`, and in the `Macro`
form. In other places, such as the `WA` configurations, the checkbox is still
used (and I think it's cleaner that way).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
