sebwrede commented on a change in pull request #1051:
URL: https://github.com/apache/systemds/pull/1051#discussion_r486376414
##########
File path: src/main/java/org/apache/sysds/parser/DataExpression.java
##########
@@ -2239,9 +2251,44 @@ public boolean isRead()
* Sets privacy of identifier if privacy variable parameter is set.
*/
private void setPrivacy(){
- Expression eprivacy = getVarParam("privacy");
- if ( eprivacy != null ){
-
getOutput().setPrivacy(PrivacyLevel.valueOf(eprivacy.toString()));
+ Expression eprivacy = getVarParam(PRIVACY);
Review comment:
Yes, I also considered splitting it up, but the current implementation
actually fits the general style of this class :stuck_out_tongue: .
I can change it now, if it is too confusing like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
